fix(acpi): Fixed how kepler searches for ACPI in hwmon #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ACPI power meter in hwmon need not always be present in
"/sys/class/hwmon/hwmon2"
This commit fixes this problem by
- looking inside each folder in "/sys/class/hwmon"
- improving the method to detect presece of acpi power meter. (this
method is inspired from lm-sensors project)
Signed-off-by: Vimal Kumar <[email protected]>
rootfs
reviewed
Apr 23, 2024
| var powerPath string | ||
| err := filepath.WalkDir(acpiPowerPath, func(path string, info fs.DirEntry, err error) error { | ||
| /* | ||
| detecthwmonACPIPath looks for an entry in /sys/class/hwmon which has an attribute |
There was a problem hiding this comment.
can you add a doc source and sample path too?
|
@vimalk78 thoughts on closing this PR? |
if community thinks this is not needed, i can close it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ACPI power meter in hwmon need not always be present in
"/sys/class/hwmon/hwmon2"This commit fixes this problem by
"/sys/class/hwmon"lm-sensorsproject)